search

ojroques / hugo-researcher

A simple resume theme for Hugo
GNU General Public License v3.0
232 stars 131 forks source link

Footnotes not working? #5

Closed HermanThiart closed 3 years ago

HermanThiart commented 3 years ago

Hey. I really like your template for its simplicity. It seems however that footnotes internal to the MD are not working correctly? It is generated, but when the footnote link is clicked it renders to the home page?

ojroques commented 3 years ago

Hello, Yes indeed there was an issue with footnotes. It was caused by a <base> tag that assigned the home page as a default target for all relative links, including footnote anchors. The issue should be fixed now. Thanks for pointing it out!

ojroques commented 3 years ago

Note: the patch that fixes this issue may broke existing relative links. For instance if you had before:

[my-link](file.pdf)

to serve http://yoursite.com/file.pdf, now you must change that link to:

[my-link](/file.pdf)
HermanThiart commented 3 years ago

Hey there. Can confirm its all working. :-) Once again thank you very much for this theme and very quick response. Awsome work!!