search

ojsde / shariff

The Shariff plugin adds social media buttons to the website without compromising the privacy of website users, using Shariff (https://github.com/heiseonline/shariff) solution.
GNU General Public License v3.0
9 stars 16 forks source link

Upgrade to OJS 3.2 #18

Closed ZahraMousavi closed 3 years ago

ZahraMousavi commented 4 years ago

Hi guys. Shariff plugin breaks in our OJS 3.2. We know that there is not a version suited for OJS 3.2 yet, but do you have any plan for upgrading the plugin?

ronste commented 4 years ago

Hi Zahra,

currently we unfortunately lack the personnel capacities to upgrade Plugins to OJS 3.2. We hope this will change by the beginning of next year at the latest. We will start upgrading plugins to OJS 3.2 as soon as our capacities allow for it.

Best wishes, Ronald

ZahraMousavi commented 4 years ago

Thanks for the quick response! We like your plugin a lot and there are several of our journals that use it. We really hope that you get the time to upgrade it as soon as possible.

All the best, Zahra

majaroenne commented 4 years ago

Hi Ronald I'm a developer working the Royal Danish Library together with Zahra Mousavi I have made minor changes to make shariff work with ojs 3.2

I would like to make a pull-request with my changes but I think I need a new branch in shariff the make the pull request against Can you please make the proper branch Best regards Maja Rønne

ronste commented 4 years ago

Hi Maja Rønne,

many thanks for contributing !!!

I created a branch dev-ojs-3_2 from master. Before I incorporate your changes into master I will test it against my local OJS 3.2 installation. Once this is done we can make an official release for 3.2.

Best wishes, Ronald