search

ojsde / shariff

The Shariff plugin adds social media buttons to the website without compromising the privacy of website users, using Shariff (https://github.com/heiseonline/shariff) solution.
GNU General Public License v3.0
9 stars 16 forks source link

Adds support for OPS and adds Brazilian Portuguese translation #26

Closed JhonathanLepidus closed 2 years ago

JhonathanLepidus commented 2 years ago

Greetings

We're sending this pull request with two contributions we think would be very relevant to this plugin.

The first one is the support to be shown in the preprint view page, in OPS. In our tests, the plugin had a good functioning in OPS either in the sidebar as in the footer. However, it did not work in the preprint view page.

The second one is a translation for Brazilian Portuguese, which could improve the plugin's adoption by more sites.

Please send us feedback on these changes.

JhonathanLepidus commented 2 years ago

Hi Ronald

I replaced the use of "submission" by "publication", as you suggested.

I also removed the changes for the javascript file. It wasn't crucial for this PR, since the most important changes are in locale files and in ShariffPlugin class.

Best wishes, Jhonathan

JhonathanLepidus commented 2 years ago

Thanks!