search

ojsde / shariff

The Shariff plugin adds social media buttons to the website without compromising the privacy of website users, using Shariff (https://github.com/heiseonline/shariff) solution.
GNU General Public License v3.0
9 stars 16 forks source link

Share the article's DOI instead of the OJS link. #37

Closed thiagolepidus closed 4 months ago

thiagolepidus commented 5 months ago

We had a request to share the DOI link instead of the OJS link, which has a higher probability of being changed over time. Integrating this functionality into the Shariff plugin seemed ideal to us. Can we submit a pull request with this feature?

We are considering three alternatives:

  1. If a DOI is available, the shared link will point to the DOI.
  2. Configurable option, maintaining the current default.
  3. Configurable option, setting the DOI link as the default.
ronste commented 5 months ago

Hi @thiagolepidus ,

that sounds good to me. You are very welcome to contribute.

Thanks, Ronald

thiagolepidus commented 5 months ago

Great, @ronste!

Do you have any preference among the suggested implementation alternatives?

ronste commented 5 months ago

Great, @ronste!

Do you have any preference among the suggested implementation alternatives?

Ohh, sorry. Forgot the alternatives. In the spirit of slowly adpating users to new features I would, for now, go with option 2). Once this is accepted we can make it the default, i.e. go for option 3).

Apart from that we have to consider that not all shareable object might have a DOI. In that case the Url should be sent.

ronste commented 5 months ago

@thiagolepidus ,

thanks for the PR. I will test it on my system, prepare a relase package and update the plugin gallery.