search

ojsde / shariff

The Shariff plugin adds social media buttons to the website without compromising the privacy of website users, using Shariff (https://github.com/heiseonline/shariff) solution.
GNU General Public License v3.0
9 stars 16 forks source link

The WhatsApp URL doesn't seem to be getting sent correctly. (stable-3_4_0) #42

Closed YvesLepidus closed 4 months ago

YvesLepidus commented 5 months ago

Testing sharing via WhatsApp, we noticed that the link is not being decoded correctly in the application. It is recommended to use the prefix 'https://api.whatsapp.com/' in the API URL, and this seems to work better. The latest versions of the Shariff already seem to have fixed this. We updated the library to version v3.3.0 and saw that the issue was resolved, so we opened a PR with this update.

ronste commented 5 months ago

Hi @YvesLepidus ,

thanks for pointing this out and, indeed, for doing the update! I wasn't aware of the new version because I always looked for new release packages.

I now also found the npm package: https://www.npmjs.com/package/shariff?activeTab=readme

I will merge your PR and do some testing and update documentation before I update the plugin gallery.

YvesLepidus commented 4 months ago

I now also found the npm package: https://www.npmjs.com/package/shariff?activeTab=readme

Cool! I also found it strange that the packages were outdated in the releases tab.