Fails to find lyrics fairly often

[nixnull]

I'm using master, specifically the arch aur 'lyvi-git' package.

It fails to find lyrics for some songs that ~mpd~ ncmpcpp succeeds at.

I tried looking at the source code to figure out how lyvi finds the lyrics, but I didn't succeed.

[ok100]

Hi, please can you test with rewrite branch (see https://bbs.archlinux.org/viewtopic.php?pid=1316595#p1316595)? I'll probably not fix anything in the old version but rewrite branch will be merged in master soon.

[sahib]

Also please make sure to have a recent version of libglyr before trying. Just reinstall it from git. (Post your glyrc --version if problem persists).

P.S: MPD has nothing to do with lyrics-retrieval.

[nixnull]

I've obtained the rewrite branch and installed all dependencies listend on the linked archlinux forum comment. Running ~/git/lyvi/lyvi.py gives me:

Traceback (most recent call last): File "./lyvi.py", line 3, in import lyvi File "/home/nichdel/git/lyvi/lyvi/init.py", line 153, in player = lyvi.players.find() File "/home/nichdel/git/lyvi/lyvi/players/init.py", line 23, in find if lyvi.config['default_player']: TypeError: 'NoneType' object is not subscriptable

[nixnull]

sahib:

I now have 1.0.1 Bloody Boar.

And I meant to say ncmpcpp, not mpd. Apologies.

[sahib]

Until ok100 has figured out that traceback:

Can you try the following and tell me if it gave you the requested output:

glyrc lyrics --artist '<the artist you tried>' --title '<the title you tried>' -v3

If not, please paste this output too.

[nixnull]

It did not find the lyrics for Da Vinci's Notebook's Internet Porn.

[nichdel@manjaro lyvi]$ glyrc lyrics --artist "Da Vinci's Notebook" --title 'Internet Porn'

• Artist : da vincis notebook
• Title : internet porn
• Language : us
• Type : lyrics

---- Triggering: musictree ---- Triggering: local ---- Triggering: lyricswiki ---- Triggering: vagalume ---- Triggering: lipwalk ---- Triggering: lyrdb ---- Triggering: elyrics ---- Triggering: lyricstime ---- Triggering: chartlyrics ---- Triggering: lyrix ---- Triggering: lyricsvip ---- Triggering: magistrix ---- Triggering: metallum ---- Triggering: lyricsreg ---- Triggering: metrolyrics

ncmpcpp seems to fetch it from lyricwiki.com, it that helps.

[sahib]

This means that this is libglyr's fault. :-(

Problem:

• Over-Normalization. Da Vinci's becomes to da vinci which is too much for lyricswiki (works when adding the apostrophe).
• This also probably addresses issue #10.

Solution:

• Either make lyvi first try to lookup the lyrics without normalization and then with them turned to aggressive.
• Disable/Specialized normalization for the lyricswiki provider (requires change in libglyr obviously).

Thanks nichdel for your work.

[ok100]

@nichdel: The traceback is fixed. I really should learn how to do unit tests in Python. Also, Lyvi can now find lyrics for "Da Vinci's Notebook - Internet Porn".

[nixnull]

@ok100 @sahib

Thanks a lot guys! It's working great now.