search

ok24601 / etoro-api

etoro trading REST API
ISC License
100 stars 49 forks source link

Replace bundled ChromeDriver in Docker #30

Closed mortenscheel closed 3 years ago

mortenscheel commented 3 years ago

It looks like the issue was a version mismatch between ChromeDriver (87) and Chrome (88).

This commit replaces the linux chromedriver in drivers/ubuntu/chromedriver with version 88 (already installed in the Docker image)

It would probably be a good idea to:

  1. Update all the bundled chromedriver binaries to version 88.
  2. Check if chromedriver is installed on the host, and only use a bundled binary if necessary.
ok24601 commented 3 years ago

it works now, nice work thanks

mortenscheel commented 3 years ago

I still get random crashes on startup so there are probably other issues.

ok24601 commented 3 years ago

yep, just seen one, i'll also look

От: Morten Scheel notifications@github.com Отправлено: 15 февраля 2021 г. 20:11 Кому: ok24601/etoro-api etoro-api@noreply.github.com Копия: ok24601 oleh_22_08@outlook.com; State change state_change@noreply.github.com Тема: Re: [ok24601/etoro-api] Replace bundled ChromeDriver in Docker (#30)

I still get random crashes on startup so there are probably other issues.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/ok24601/etoro-api/pull/30#issuecomment-779381822, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADHNNVSEOI36W4JVUOY4ZSDS7FPVFANCNFSM4XVBODSA.