Add default rpc port - Githubissues

okTurtles / dnschain

A blockchain-based DNS + HTTP server that fixes HTTPS security, and more!

https://okturtles.com

Other

1.73k stars 169 forks source link

Add default rpc port #169

Closed ts468 closed 9 years ago

taoeffect commented 9 years ago

Since this was a very minor change we'll wait until more stuff is added before releasing another point update. Thanks for the enhancement! :+1:

ts468 commented 9 years ago

Thanks for the fast merge! I'm about to integrate dnschain into NixOS and I hoped I could use the updated version for it. However, that would require it to be available as NPM package. Can you estimate how long it will take until the next release?

taoeffect commented 9 years ago

You should be able to set up everything you need without this change.

You've got a lot of options:

Create the namecoin.conf file that DNSChain reads (you can even tell DNSChain where to look for it if you don't like the default location for some reason), and set your rpcport value there.
You might even be able to just set it via an environment variable or a command line option since we use nconf (look at nconf's docs for more info on how to do that, I don't remember, but it might be as simple as setting RPCPORT=8336).

ts468 commented 9 years ago

Thanks! Unfortunately, I can't use namecoin.conf the way other Linux distributions do. I can have a look whether I can set it as an environment variable, but somehow the cleanest solution would definitely be a new release ;)

ts468 commented 9 years ago

But don't worry, I can patch things locally as well!

taoeffect commented 9 years ago

Oh, and the environment variable (or cli args) probably should be capitalized exactly as it is in the conf, so rpcport=8336 (and keep in mind that if you use any other blockchain with that same named conf variable, it will set it to that as well, which would result in a conflict).