search

okTurtles / group-income-simulator

Visualizer for https://github.com/okTurtles/group-income
https://groupincome.org/simulator/
1 stars 0 forks source link

Incorrect tooltip on mobile #3

Closed SebinSong closed 6 days ago

SebinSong commented 1 week ago

1. Problem

image

(Confirmed this happens in the version of main branch before mergence of the PR #2)

On mobile device, the tooltip that is spawned upon clicking on the user banner UI component incorrectly says who they are. This issue is only happening in mobile and caused by how the app currently detects user-click. Normally, click or touchdown event is used but the app currently tracks the pointer only using mousemove handler in the canvas area, which is an incomplete logic for any touch devices.

2. Solution

Improve the logic that detects user-click so it's applicable to both desktop / touch-devices and fix the issue.

taoeffect commented 1 week ago

Nice catch! Also, in that screenshot for some reason the buttons at the bottom are poorly arranged across two rows instead of one 🤔

SebinSong commented 1 week ago

@taoeffect That is a screenshot of the previous version of main before my recent PR #2 . So no worries.