This bug-fix hasn't actually been tested in my android phone as this project doesn't have a tool to do so (like browserSync in the GI project). So I think we can only check if the fix works after this PR is deployed to the PROD website. (But let me know if you do know a way to do the mobile device test)
But there was actually a very similar issue in the GroupIncome I fixed a while ago.
The cause of the issue there was that the resize handler didn't take into account the case where the viewport change is caused by the keyboard pane popping out on mobile-devices.
Reading through the related logic here, I felt quite confident that the issue was caused by the same reason so I pushed a fix and sent a PR. If the fix won't work after deployment I can come back to fixing again.
closes #6
@taoeffect
This bug-fix hasn't actually been tested in my android phone as this project doesn't have a tool to do so (like
browserSyncin theGIproject). So I think we can only check if the fix works after this PR is deployed to the PROD website. (But let me know if you do know a way to do the mobile device test)But there was actually a very similar issue in the
GroupIncomeI fixed a while ago. The cause of the issue there was that theresizehandler didn't take into account the case where the viewport change is caused by the keyboard pane popping out on mobile-devices. Reading through the related logic here, I felt quite confident that the issue was caused by the same reason so I pushed a fix and sent a PR. If the fix won't work after deployment I can come back to fixing again.