search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
329 stars 43 forks source link

Automatically ask users whether they want to change their income details when the mincome changes #1973

Open dotmacro opened 5 months ago

dotmacro commented 5 months ago

Problem

Currently, the user only sees the "mincome changed" prompt if they click on the "mincome has changed" notification, meaning they will not see it if they simply read the notification and then mark it as read. Likewise, they will not see it if they never click the notification bell.

After clicking the notification and triggering the prompt, other than dismissing the prompt modal, the user's choice has no impact. Clicking "yes" (indicating that they make at least the mincome) does not take them to anywhere they might change/confirm their pledge. Clicking "no" (indicating that they do not meet the mincome) does not either take them to where they can remove their pledge nor automatically change their pledge to $0. It also does not take them to anywhere they might enter their income/need.

Solution

See also #1125

  1. After a mincome-changing proposal passes, the prompt should appear for all users when they next log in.
  2. The prompt flow should be complete:
    • If the user clicks "yes", they should be taken to a place to change/confirm their pledge (e.g. incomedetails modal, contributions page).
    • If the user clicks "no", they should be taken to a place to enter their income/need (e.g. incomedetails modal, contributions page). If not handled by the income/need entry, then pledge should be automatically changed to $0.
SebinSong commented 5 months ago

@dotmacro , @taoeffect

... Clicking "yes" (indicating that they make at least the mincome) does not take them to anywhere they might change/confirm their pledge. Clicking "no" (indicating that they do not meet the mincome) does not either take them to where they can remove their pledge ...

From my investigation, The logic that takes care of this is actually in place (also used to work properly from what I remember) but is somehow broken now. I'm going to work on bug-fixing this along with implementing the requirements of this issue.