search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Improve "Cannot join already joined group" UX #2051

Open dotmacro opened 5 months ago

dotmacro commented 5 months ago

Problem

If user is logged in and clicks an invite link for a group they're already a member of, they're shown a full-screen error message.

  1. The large text indicates that the link itself is invalid (which is confusing because the link is valid) and the smaller text that explains the actual issue is not very user-friendly.
  2. The included href is neither clickable nor human-readable (to the average user). [In this instance, copy-pasting the URL also does not "report the error" but rather redirects to the group dashboard.]

alreadyJoined

Solution

  1. Possible solutions include:
    1. When user is already a member, change "This invite is not valid" to "You are already a member". If we're showing the full error text on the modal, then the error message more user-friendly by showing the group name instead of '${groupContractID}`. (I assume if we know user is already a group member, then the group name is accessible.)
    2. Alternatively, automatically redirect the user to that group's dashboard. Optional: include alert indicating user was already a group member
    3. If included, links in the error message should be clickable, with the anchor text solving the "human-readable" problem.
dotmacro commented 4 months ago

Just clicked invite link for a group I was already signed in to, and received the old error again.

alreadyJoined-again

Commenting here as a note. Will reopen the issue if I can reproduce.

taoeffect commented 4 months ago

I saw this too, I'll re-open, but if you have steps please post them!

dotmacro commented 4 months ago

I saw this too, I'll re-open, but if you have steps please post them!

I don't recall doing anything tricky or special -- just clicked the invite link for a group I was already signed in for.

Maybe a heisenbug because when I tried to reproduce, I got the correct error. image

SebinSong commented 4 months ago

@taoeffect @dotmacro Below is how I encountered the invalid invite screen.

[Step 1]. sign up for user-1 and create a group A. And then copy the anyone invite of the group. [Step 2]. sign up for user-2 and then join group A using the invite from Step 1. above.

[Step 3]. Launch another browser, and then paste the anyone invite from Step 1. In the sign-up screen it lauches, click the 'Log in' button.

[Step 4.] Log in as user-2. and you see that invalid invite screen.

SebinSong commented 4 months ago

FYI, I discovered this scenario above when,

  1. Greg gave out the invite link to newly-created gig group in a new testing site, a couple of weeks ago (or could be last week)
  2. I signed up & joined the group via that link. (I think I did it on my desktop)
  3. A couple of days later, I opened that same link on my phone. As that was the first time using that link on my phone since the new testing site was generated, It launched the sign up form there.
  4. Knowing I already joined the group couple of days ago, I clicked on that 'Log in' button there.
  5. Logged in, and I encountered that invalid invite screen.