okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

#2144 - Updating user avatar while group settings is open updates both avatars #2207

Closed SebinSong closed 4 months ago

SebinSong commented 4 months ago

closes #2144 (great catch @dotmacro, btw. This is something I implemented a while ago.)

AvatarUpload.vue subscribes to AVATAR_EDITED for when the user is done with editing the image. But then, when two components that have AvatarUpload.vue are both in the screen, they all end up listening to this event and updating the avatar at the same time. As a fix, I've placed avatarType prop in the event payload as an identifier, so that the component knows whether the event is meant for it or not.

cypress[bot] commented 4 months ago

Passing run #2656 ↗︎

0 114 8 0 Flakiness 0

Details:

Merge 0a42b6feeec136a1b8579018976e60cab6e1f571 into d059794bd2fa591c2caa97a83d41...
Project: group-income Commit: a9a7300a82 ℹ️
Status: Passed Duration: 10:26 💡
Started: Jul 16, 2024 6:28 AM Ended: Jul 16, 2024 6:39 AM

Review all test suite changes for PR #2207 ↗︎