okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Unread messages notification badge not appearing for messages in channels #2216

Closed dotmacro closed 4 months ago

dotmacro commented 4 months ago

Problem

The notification badge is not appearing on Chat in the menubar when there are unread messages. Nor is it appearing on the channels list. This is affecting both public and private channels, but not DMs.

  1. User1 sends messages in general and in a private channel. chatNotificationBadge

  2. User2 does not see any notification badge on Chat or unread message counter on general. (User2 is not a member of private channel). chatNotificationBadge-none\

  3. User3 does not see any notification badge on Chat, or unread message counters on general or the private channel. chatNotificationsMissing

  4. User1 Sends a DM to User3.

  5. User3 does see a notification badge both on Chat and in the DM list (as an unread message counter). chatNotifications--DMsOK

Solution

  1. Ensure notification badge appears on Chat in the left menubar when there are unread messages.
  2. Ensure notification badge appears on proper channel name(s) when there are unread messages in any.
Silver-IT commented 4 months ago

I am not sure where the discussion is, but I remember that we made agreement on displaying red badge on the Chat menu of sidebar only when there are unreadMessages. unreadMessages contains mentions(e.g., @alexjin, @sebin, ...) from any channels, messages of INTERACTIVE type (e.g., @alexjin wants to change group's mincome. See proposal) from any channels, and any messages from DMs. So just creating a simple message in a public/private chatroom doesn't make badge on the Chat menu.

And, as we can see in the following Figma design, it also says the badge will be display only there is at least 1 notifications. The notifications is what we implemented in our codes as unreadMessages. image

It also works same to the badges of channels on the right side of the app.

cc: @dotmacro, @taoeffect

Silver-IT commented 4 months ago

We are currently display badges for those unreadMessages. image image

dotmacro commented 4 months ago

You’re completely correct @Silver-IT , thank you. Closing.