search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Properly handle/enforce `GROUP_NAME_MAX_CHAR` on group settings page #2238

Closed dotmacro closed 4 months ago

dotmacro commented 4 months ago

Problem

On the Group Settings page, the text box for the group name has no char limit in the UI. However, there's clearly an enforced limit on the backend because the error message indicates that groupName cannot exceed 50 chars.

groupSettings--groupNameUnlimited--Error

Solution

Fix, presumably by handling GROUP_NAME_MAX_CHAR the same here as during group creation.

dotmacro commented 4 months ago

Additionally, "You can report the error" in the error message is not a link, and not clickable. @taoeffect Should #1945 be reopened, or is this a new issue?

SebinSong commented 4 months ago

@dotmacro

Additionally, "You can report the error" in the error message is not a link, and not clickable. @taoeffect Should https://github.com/okTurtles/group-income/issues/1945 be reopened, or is this a new issue?

You can see them as separate issues as those are two different UI components. I can handle that bug as part of this task.