Fix styling issue of more options menu

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.

https://groupincome.org

GNU Affero General Public License v3.0

329 stars 43 forks source link

Fix styling issue of more options menu #2254

Closed Silver-IT closed 1 month ago

Silver-IT commented 1 month ago

Summary of Changes

Closes #2234

cypress[bot] commented 1 month ago

Passing run #2805 ↗︎

112

Details:

Merge 8181956a43f4156f48aa6e986a4cc77cc5b51c28 into 37d9f4aab072e42aa0e452b6c174...
Project: group-income	Commit: `e714d15a39 ℹ️`
Status: Passed	Duration: 10:47 💡
Started: Jul 25, 2024 9:28 PM	Ended: Jul 25, 2024 9:39 PM

Review all test suite changes for PR #2254 ↗︎

SebinSong commented 1 month ago

Great fix @Silver-IT .

calculating available space is tall enough for menu is a good idea and seems to work well too. One thing I observed is, depending on the viewport width, the height of each menu item becomes different. (e.g. in below layout, the menu is 54px tall whereas the calculation is based on the assumption that it's always 36px). Could you enhance the calculation to take this into account?