#2217 - Add UI limit for chat message

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.

https://groupincome.org

GNU Affero General Public License v3.0

331 stars 44 forks source link

#2217 - Add UI limit for chat message #2272

Closed SebinSong closed 3 months ago

SebinSong commented 3 months ago

closes #2217

Currently CHATROOM_MAX_MESSAGE_LEN = 20000 and I've added maxlength attribute for it (which makes sure string beyond that limit gets cut off), but not that n/20000 indicator UI because I thought it will be rare that the user types messages longer than that and having it won't be that useful compared to other places. But let me know if we need it in place here too.

SebinSong commented 3 months ago

stringMax(CHATROOM_MAX_MESSAGE_LEN) validator in chatroom.js contract has already been added before. So no need to take care here.

cypress[bot] commented 3 months ago

Test summary

112 • 0 • 10 • 0

Run details


Project	group-income
Status	Passed
Commit	794b731d9e ℹ️
Started	Aug 5, 2024 10:44 PM
Ended	Aug 5, 2024 10:55 PM
Duration	10:57 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 89

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

SebinSong commented 3 months ago

@taoeffect Increased max-height for desktop size screen to 12.25rem and also fixed the hidden scrollbar bug.