okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

lastLoggedIn value is still not being updated properly #2288

Closed taoeffect closed 2 months ago

taoeffect commented 3 months ago

Problem

Seems like #1997 was never fixed properly.

In our GIG group, andrea appears as not logged in for the past 14 days for me even though she has.

Solution

There might be multiple problems, but I've noticed at least that unlike identity-kv.js, there is no corresponding gi.actions/identity/kv/load type call that happens when the app comes back online. Here's an example from identity-kv.js:

sbp('okTurtles.events/on', ONLINE, () => {
  sbp('gi.actions/identity/kv/load').catch(e => {
    console.error("Error from 'gi.actions/identity/kv/load' after reestablished connection:", e)
  })
})

There may be other issues too.