okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
329 stars 43 forks source link

#2305 Implement in-app notifications for non-monetary contributions #2314

Closed SebinSong closed 4 days ago

SebinSong commented 1 month ago

closes #2305

Currently there is two places where users can add/remove/update their non-monetary contributions: 1. /contributions page. 2. IncomeDetails.vue modal.

In 1., the item is added/removed/updated one by one. Whereas in 2., multiple items can be added/removed/updated at a time. In this case, the notification sentence can have compound expressions (not sure if this is a correct english words but anyways) eg. Teach Javascript and 2 more or added Teach Python and removed Teach how to play piano and 1 more etc.

Clicking on the notification messages navigates to /contributions page where they can see the full list of the group's non-monetary contributions.

Hope it looks good.

cypress[bot] commented 1 month ago

group-income    Run #3131

Run Properties:  status check passed Passed #3131  •  git commit ee832ee8d4 ℹ️: Merge 7149a75bfa65c90088bd79b0cf4adc13cdf28bc6 into 8138b12f6d70ad9447e338047d41...
Project group-income
Branch Review sebin/task/#2305-notifications-for-non-monetary
Run status status check passed Passed #3131
Run duration 09m 13s
Commit git commit ee832ee8d4 ℹ️: Merge 7149a75bfa65c90088bd79b0cf4adc13cdf28bc6 into 8138b12f6d70ad9447e338047d41...
Committer Sebin Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
SebinSong commented 1 month ago

This PR is ready besides the group-chat heisen-bug

taoeffect commented 4 weeks ago

Thanks @SebinSong. Supposedly @corrideat thinks his PR #2294 (once it's ready) should address the heisenbug.