search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Fix #2309: Add badge on mobile if there is an unread message #2324

Closed pieer closed 1 month ago

cypress[bot] commented 2 months ago

group-income    Run #3168

Run Properties:  status check passed Passed #3168  •  git commit fa3928a3fb ℹ️: Merge a97ad2cdd086df49ee9893d6a155e68d709bcf79 into 9fd5e1643cf0396ad0dfb58b6d45...
Project group-income
Branch Review task/#2309-new-design-on-mobile-chat
Run status status check passed Passed #3168
Run duration 09m 22s
Commit git commit fa3928a3fb ℹ️: Merge a97ad2cdd086df49ee9893d6a155e68d709bcf79 into 9fd5e1643cf0396ad0dfb58b6d45...
Committer Pierre Schweiger
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
corrideat commented 2 months ago

We need a better design here I think.

Another issue is that the badge appears to be floating around, so it's not immediately obvious that it's part of the button.

pieer commented 2 months ago

I've updated the logic: If we are anywhere in the app but the chat group, we show a notification in the left menu to indicate a new message. If we are in the group chat page, we have on mobile, an indication on the right panel to indicate new message.

I've updated the icon design to have a background attached to the notification, so the badge is not floating anymore, but attached to the button.

If there is already notification for something else, the main menu show that notification. When the user open the menu he can either look at the notification but also can see that there is a new message in the chat