okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Chelonia in SW #2357

Open corrideat opened 2 months ago

corrideat commented 2 months ago

Tests currently passing:

For the non-passing tests, a common theme seems to be that document is undefined. I believe this to be related to DOMPurify, and the best solution seems to be removing it from contracts and the service worker.

Other things that are broken, but which should be easier to fix:

cypress[bot] commented 1 month ago

group-income    Run #3421

Run Properties:  status check passed Passed #3421  •  git commit 5991f88bb7 ℹ️: Merge 63caf86b4fd5a36d86abdfbd8103c551af5390e0 into 3b142e94445de8ab49b435e8d4bd...
Project group-income
Branch Review feature/chelonia-in-service-worker
Run status status check passed Passed #3421
Run duration 10m 55s
Commit git commit 5991f88bb7 ℹ️: Merge 63caf86b4fd5a36d86abdfbd8103c551af5390e0 into 3b142e94445de8ab49b435e8d4bd...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
taoeffect commented 4 weeks ago

After signing up a new user, I got the last two errors:

Screenshot 2024-10-24 at 11 11 49 AM

service-worker.js:193:

Screenshot 2024-10-24 at 11 12 41 AM

Note: this happened twice in FFDev, once for u1, and once for u2 when joining using invite link.

taoeffect commented 4 weeks ago

I'm also not hearing notification sounds upon @mention. Did you merge latest master that fixed this?

taoeffect commented 4 weeks ago

In Safari, u3 joined, and u2 (in FFDev) made a proposal, then u3 switched form Chat to Dashboard to see proposal, then u1 approved proposal (in FFDev), then u3 (in Safari) switched back to Chatroom:

Screenshot 2024-10-24 at 11 18 17 AM

corrideat commented 4 weeks ago

After signing up a new user, I got the last two errors:

I need some more background on what exactly you were doing (e.g., what you were doing before). The mismatch error indicates that the event received is for the wrong identity contract. For the pubsub error, I don't need additional information at this point.

I'm also not hearing notification sounds upon @mention. Did you merge latest master that fixed this?

Presumably not. I've just merged master.

In Safari, u3 joined, and u2 (in FFDev) made a proposal, then u3 switched form Chat to Dashboard to see proposal, then u1 approved proposal (in FFDev), then u3 (in Safari) switched back to Chatroom:

I see. This looks like an issue with structuredClone somewhere. I don't have Safari so testing this might be challenging if it's a Safari-only issue.

socket-security[bot] commented 1 week ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@apeleghq/rfc8188@1.0.7 None 0 0 B

🚮 Removed packages: npm/@exact-realty/rfc8188@1.0.5

View full report↗︎