Open corrideat opened 2 months ago
Passed #3421
•
5991f88bb7 ℹ️: Merge 63caf86b4fd5a36d86abdfbd8103c551af5390e0 into 3b142e94445de8ab49b435e8d4bd...
Project |
group-income
|
Branch Review |
feature/chelonia-in-service-worker
|
Run status |
Passed #3421
|
Run duration | 10m 55s |
Commit |
5991f88bb7 ℹ️: Merge 63caf86b4fd5a36d86abdfbd8103c551af5390e0 into 3b142e94445de8ab49b435e8d4bd...
|
Committer | Ricardo Iván Vieitez Parra |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
10
|
Skipped |
0
|
Passing |
111
|
View all changes introduced in this branch ↗︎ |
After signing up a new user, I got the last two errors:
service-worker.js:193
:
Note: this happened twice in FFDev, once for u1
, and once for u2
when joining using invite link.
I'm also not hearing notification sounds upon @mention. Did you merge latest master
that fixed this?
In Safari, u3
joined, and u2
(in FFDev) made a proposal, then u3
switched form Chat to Dashboard to see proposal, then u1
approved proposal (in FFDev), then u3
(in Safari) switched back to Chatroom:
After signing up a new user, I got the last two errors:
I need some more background on what exactly you were doing (e.g., what you were doing before). The mismatch error indicates that the event received is for the wrong identity contract. For the pubsub error, I don't need additional information at this point.
I'm also not hearing notification sounds upon @mention. Did you merge latest master that fixed this?
Presumably not. I've just merged master
.
In Safari, u3 joined, and u2 (in FFDev) made a proposal, then u3 switched form Chat to Dashboard to see proposal, then u1 approved proposal (in FFDev), then u3 (in Safari) switched back to Chatroom:
I see. This looks like an issue with structuredClone
somewhere. I don't have Safari so testing this might be challenging if it's a Safari-only issue.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/@apeleghq/rfc8188@1.0.7 | None | 0 |
0 B |
🚮 Removed packages: npm/@exact-realty/rfc8188@1.0.5
Tests currently passing:
For the non-passing tests, a common theme seems to be that
document
is undefined. I believe this to be related to DOMPurify, and the best solution seems to be removing it from contracts and the service worker.Other things that are broken, but which should be easier to fix: