okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Close proposals when they expire #2373

Closed dotmacro closed 4 weeks ago

dotmacro commented 1 month ago

Problem

On testing, proposals are not closed when they expire. This was tested with a proposal that closed more than two months ago.

expiredProposal

Even though the proposal has expired, the "Change vote" link remains, and works.

expiredProposal--canVote

Even though the proposal has expired, the user can change their vote.

expiredProposal--changedVote

Solution

When proposals expire, they should be closed. This means that:

SebinSong commented 1 month ago

Apparently this error message is the cause of the issue: