Direct Message notifications broken on `master` - Githubissues

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.

https://groupincome.org

GNU Affero General Public License v3.0

331 stars 44 forks source link

Direct Message notifications broken on `master` #2386

Closed taoeffect closed 4 weeks ago

taoeffect commented 1 month ago

Problem

It seems somehow direct message notifications are broken on master now.

They do not result in a sound
They do not show the unread red badge number
They do not send a browser notification either

Steps to reproduce:

[Container Tab 1] u1 creates group, copies invite link
[Container Tab 2] u2 joins group
[Container Tab 2] u2 sends u1 a DM

There should be a DM sound and the red badge should appear showing a 1 next to u2's name in the chat view showing the DM list.

Solution

Fix the bug.
Add a single test with this scenario to prevent us from missing it again.

taoeffect commented 4 weeks ago

Closed by @SebinSong in #2389