search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

#2373 - Bug: Proposal does not expire #2388

Closed SebinSong closed 4 weeks ago

SebinSong commented 1 month ago

closes #2373

I can see the app now handles proposal expiration correctly.


It appears that gi.actions/group/markProposalsExpired used to only take one proposal ID as the param(data.proposalHash) and then was changed to take an array of IDs(data.proposalIds) later. But the relevant part in frontend/controller/actions/group.js file has not been updated to take this into account, which lead to causing below runtime error:


So made a fix accordingly.

cypress[bot] commented 1 month ago

group-income    Run #3327

Run Properties:  status check passed Passed #3327  •  git commit 68a6a6cbba ℹ️: Merge 6c84e691aa17117f5e7d6b57c27be50accdcfbcc into cd4e463201e39c77101340b487a8...
Project group-income
Branch Review sebin/task/#2373-close-proposal-bug
Run status status check passed Passed #3327
Run duration 09m 09s
Commit git commit 68a6a6cbba ℹ️: Merge 6c84e691aa17117f5e7d6b57c27be50accdcfbcc into cd4e463201e39c77101340b487a8...
Committer Sebin Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
taoeffect commented 1 month ago

Note to self when testing this: be sure to test with existing data from server to verify that old messages won't be broken by this PR.