search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

Fix the broken DM notification #2389

Closed SebinSong closed 1 month ago

SebinSong commented 1 month ago

resolve solution 1. of #2386

I can see the notification works properly now.

notification works

cypress[bot] commented 1 month ago

group-income    Run #3329

Run Properties:  status check passed Passed #3329  •  git commit 7209a1178a ℹ️: Merge 4209910e57f218eee3b85b2042bcf7a54e70b2db into cd4e463201e39c77101340b487a8...
Project group-income
Branch Review sebin/task/#2386-direct-message-notification-broken
Run status status check passed Passed #3329
Run duration 09m 09s
Commit git commit 7209a1178a ℹ️: Merge 4209910e57f218eee3b85b2042bcf7a54e70b2db into cd4e463201e39c77101340b487a8...
Committer Sebin Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
SebinSong commented 1 month ago

@taoeffect The PR is ready for review.

I can work on updating(or creating) a test item to check for this bug separately from this PR later.