search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

#2393 - Add `ButtonSubmit.vue` for 'Send message' button #2402

Closed SebinSong closed 3 weeks ago

SebinSong commented 3 weeks ago

closes #2393

Apparently, the tooltip is dismissed immediately after the 'Send message' button when this.createDirectMessage(this.contractID) triggered by it is a series of async operation. https://github.com/okTurtles/group-income/blob/83f11f1ed18c5d3740088cabd97f86e93ff9617e/frontend/views/components/ProfileCard.vue#L171

So replaced the button with ButtonSubmit.vue as the visual indicator so that it gets dismissed after the DM is created.

Hope it sounds good and let me know if there is addition al thing needed along with this.

cypress[bot] commented 3 weeks ago

group-income    Run #3366

Run Properties:  status check passed Passed #3366  •  git commit 644c0bc627 ℹ️: Merge 8829562152a6144a98572b766e0676979a0f1ff8 into a1294ef61d3f284dee5ef03efcea...
Project group-income
Branch Review sebin/task/#2393-same-multiple-dms-issue
Run status status check passed Passed #3366
Run duration 08m 59s
Commit git commit 644c0bc627 ℹ️: Merge 8829562152a6144a98572b766e0676979a0f1ff8 into a1294ef61d3f284dee5ef03efcea...
Committer Sebin Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎