SebinSong
commented
3 weeks ago @taoeffect
Observations
I investigated this issue for some time and found out that this also happens in desktop browsers too.
And this(notification displayed with missing data) seems to only happen when:
- the DM was sent while the receiver(u2 here) was not online,
- Then later u2 launches the app again and immediately sees the notifications emitted.
Possible causes
From my investigation, It appears that the root-cause is that some sideEffects of 'chatroom.js' contracts are executed too soon before user-settings are fully loaded to the Vuex store.
As you are aware too, there are multiple places in the source-code where the app uses sbp('state/vuex/state') and/or sbp('state/vuex/getters') to determine whether a message notification needs to be sent or not. For examples,
eg1)
eg2)
and so on.
Something like sbp('state/vuex/state').loggedIn.identityContractID here is actually based on the assumption that the user-setting data has been completely loaded to the Vuex store by the time the app executes this line.
But then what I've observed is these are executed before sbp('gi.db/settings/load', SETTING_CURRENT_USER) and await sbp('gi.app/identity/login', { identityContractID }) operations in main.js (reference below) are completed.
below is a devtool console.log screenshot showing messageReceivePostEffect(...) is executed earlier than sbp('gi.db/settings/load', SETTING_CURRENT_USER) operation is done.
So when we have const me = sbp('state/vuex/state').loggedIn.identityContractID, a check like me === innerSigningContractID would become undefined === innerSigningContractID because sbp('state/vuex/state').loggedIn is evaluated to false.
It's not clear since when this has been the case as I'm not the expert in this area.
It seems like the complete fix is to make sure all operations related to sbp('gi.db/settings/load', SETTING_CURRENT_USER) block in main.js are done early enough that things like sbp('state/vuex/state') in contract sideEffects fetch the expected data. If you agree with this reasoning, I feel this fix should be taken care of by someone who has more thorough expertise in this area than myself..!
What's your thoughts?
Thanks,
taoeffect
Problem
When I opened up the PWA on mobile I got this notification. But it's a message I DM'd to someone else, so I shouldn't be notified and also it shouldn't say "undefined":
Solution