search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

#2406 - payment table UI issue #2410

Open SebinSong opened 3 weeks ago

SebinSong commented 3 weeks ago

closes #2406 closes #2415

As mentioned in this Slack thread, horizontal scrollbar creates another critical issue where the menu dropdown is cropped or even not visible at all in some cases. So decided to revert the previous fix and instead extended current css media-queries settings to make sure nothing overflows the table layout.

[case 1 - table has enough space]

image


[case 2- table does not have enough space]

image

Hope it looks good!

cypress[bot] commented 3 weeks ago

group-income    Run #3370

Run Properties:  status check passed Passed #3370  •  git commit 99e89a1272 ℹ️: Merge 091647d879cfb5ceac40667e1cdf4e177efb0f54 into 3b142e94445de8ab49b435e8d4bd...
Project group-income
Branch Review sebin/task/#2406-payment-table-issue
Run status status check passed Passed #3370
Run duration 09m 04s
Commit git commit 99e89a1272 ℹ️: Merge 091647d879cfb5ceac40667e1cdf4e177efb0f54 into 3b142e94445de8ab49b435e8d4bd...
Committer Sebin Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
corrideat commented 1 week ago

LGTM