search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

#2412 `<Enter>` key issue on mobile #2413

Open SebinSong opened 2 weeks ago

SebinSong commented 2 weeks ago

closes #2412

I can write multi-line messages from mobile now.

cypress[bot] commented 2 weeks ago

group-income    Run #3381

Run Properties:  status check passed Passed #3381  •  git commit 594cbbdbec ℹ️: Merge 51122f709512affee015a190e8bb6a11e73fa332 into 3b142e94445de8ab49b435e8d4bd...
Project group-income
Branch Review sebin/task/#2412-enter-key-issue-on-mobile
Run status status check passed Passed #3381
Run duration 08m 45s
Commit git commit 594cbbdbec ℹ️: Merge 51122f709512affee015a190e8bb6a11e73fa332 into 3b142e94445de8ab49b435e8d4bd...
Committer Sebin Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
corrideat commented 1 week ago

LGTM.

I'm not so happy about the mobile detection, but then I can't really find a better way of doing this. What I'd do is maybe add a setting or a UI component (like a checkbox or dropdown) to explicitly select the Enter behaviour (tri-state: 'auto', ⇧ Shift+Enter for new line, Enter for new line) but that may be beyond the scope of this issue.