search

okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

#2418 - Show error UI for mincome maximum #2420

Open SebinSong opened 1 week ago

SebinSong commented 1 week ago

closes #2418

Please let me know if we want to change the error sentence.

cypress[bot] commented 1 week ago

group-income    Run #3385

Run Properties:  status check passed Passed #3385  •  git commit 7f989cf0ad ℹ️: Merge 9189dccd64bb3d49d85ccc6ae3c7ff300fba53eb into 3b142e94445de8ab49b435e8d4bd...
Project group-income
Branch Review sebin/task/#2418-incorrect-mincome-limit-error
Run status status check passed Passed #3385
Run duration 08m 57s
Commit git commit 7f989cf0ad ℹ️: Merge 9189dccd64bb3d49d85ccc6ae3c7ff300fba53eb into 3b142e94445de8ab49b435e8d4bd...
Committer Sebin Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎
corrideat commented 1 week ago

LGTM in terms of fixing the issue, although not a fan of adding arbitrary limits like these (OTOH, the limit needs to exist regardless, even if it were the full range of numbers allowed by JS).