okTurtles / group-income

A decentralized and private (end-to-end encrypted) financial safety net for you and your friends.
https://groupincome.org
GNU Affero General Public License v3.0
331 stars 44 forks source link

duplicate "Anyone" links #2424

Open dotmacro opened 4 days ago

dotmacro commented 4 days ago

Problem

Sometimes a second "Anyone" link is generated. Each link is valid for the remaining number of invites, potentially doubling the possible group size.

anyoneLinksDuplicates

Steps to reproduce: Unclear.

Solution

Fix.

  1. Groups only need one "Anyone" link at a time, so previous "Anyone" links should be immediately revoked when a new one is generated.
  2. Existing invite links can cumulatively be valid for more than the number of remaining user spots. (For example, an "Anyone" link can be valid for all remaining spots while there are also individual invite links.) However, every time any invite link is used, the remaining user spots should decrement by 1.