okTurtles / group-income

Voluntary Basic Income system that's decentralized and end-to-end encrypted.
https://groupincome.org
GNU Affero General Public License v3.0
328 stars 43 forks source link

Revoked invites shouldn't work. #970

Open sdegutis opened 3 years ago

sdegutis commented 3 years ago

Problem

When a revoked invite link is followed, the link seems to work, but the app messes up.

Solution

It should show an error page saying the link was revoked. We should change inviteGuard to check if the status is revoked.

SebinSong commented 3 years ago

Could someone help me with reproducing this issue? How can I make a revoked invite show up in the group-setting page?

Thanks!

taoeffect commented 3 years ago

@SebinSong It's unclear to me from Steven's problem description how to reproduce the issue, but have you tried copying the invite link before it's revoked, revoking it, and then visiting it in another container tab (or different browser)?

sdegutis commented 3 years ago

🤷 If it's not happening then mark it cannot reproduce.