search

okafohenry / task-tracker

0 stars 0 forks source link

Review #1

Open ogunsoladebayo opened 10 months ago

ogunsoladebayo commented 10 months ago

Pros

Cons

Summary

@okafohenry Work on the issues above and request a re-review on or before 18/12/23, 14:00 WAT

okafohenry commented 10 months ago

Hello, thank you for your review and feedback. I will work to get the cons sorted but I'm appealing for a deadline extension. This is because I missed out on the email notification and as a result, I'm just getting to see the reply.

I look forward to your reply and hope for your approval on the extension request. thanks.

On Sun, Dec 17, 2023 at 8:03 PM Usman Ogunsola @.***> wrote:

Pros

  • clean, Intuitive UI.
  • Nice and balanced use of animations.
  • Regular coding pattern and conventional style guides

Cons

-

Bad colour matching on login page Screenshot.from.2023-12-17.19-11-18.png (view on web) https://github.com/okafohenry/task-tracker/assets/57511444/51bd0994-ed1a-4f50-8a2d-121f4ba4577d

No email validation on email field

All users see the same set of tasks; tasks should be filtered by username.

Unable to add tasks; issue with API Screencast from 2023-12-17 19-28-00.webm https://github.com/okafohenry/task-tracker/assets/57511444/cab98554-79eb-4a9d-8575-eae1ad9ba19b

Too many console.log()s

Rusty API call logic, quite unreadable.

Too many loose typing; entities could be more strictly typed.

Summary

  • Minimalist design with good feel. however, there are few issues. Recommending a re-review.

@okafohenry https://github.com/okafohenry Work on the issues above and request a re-review on or before 18/12/23, 14:00 WAT

— Reply to this email directly, view it on GitHub https://github.com/okafohenry/task-tracker/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJKXQVSA5PZHBCUON3FQOCTYJ46WVAVCNFSM6AAAAABAYRQUIOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DKMZTG4YDONY . You are receiving this because you were mentioned.Message ID: @.***>