search

okamibl / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter
0 stars 0 forks source link

Invalid lines containing unclosed parentheses cause xy-VSFilter to throw an exception and crash #73

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The attached script crashes MPC-HC for me around 02:23. The error it throws 
isn't particularly specific, just a runtime error in Microsoft C++. I'm running 
3.0.0.1 on MPC-HC build 1.5.3.3941, with madVR 0.79 and LAV 
Video/Audio/Splitter 0.44. I suspect that it has something to do with the 
transform on the font spacing, since that's the only strange thing about the 
line where it crashes.

Original issue reported on code.google.com by spacepir...@gmail.com on 18 Jan 2012 at 5:33

Attachments:

GoogleCodeExporter commented 8 years ago 
Reproduced. The crash happens at an invalid line caused by unclosed parentheses 
in Commies script. There is actually another invalid tag right before that |fad 
instead of \fad, but xy-VSfilter handles that one fine.

Commie's broken line:
Dialogue: 
0,0:02:22.74,0:02:22.95,OP,,0000,0000,0000,,{\blur3\bord2\t\c&H136541&\3c&H0B0F0
E&)}The reason I have

What it should be:
Dialogue: 
0,0:02:22.74,0:02:22.95,OP,,0000,0000,0000,,{\blur3\bord2(\t\c&H136541&\3c&H0B0F
0E&)}The reason I have

I've attached a fixed script '[Commie] Nisemonogatari - 02 [0BD2EE1E].ass'. You 
can either use mkvtoolnix to remux & replace the script, or just place it in 
the same directory and have it used as an external script.

The other attachment 'invalid_line_unclosed_parentheses.ass' is just an 
isolated test case for our reference. Since VSFilter 2.39/2.40 doesn't crash on 
the invalid line, this is a regression which we'll attempt to fix.

Do you feel comfortable reporting these two script typos to Commie staff on IRC 
#commie-subs@irc.rizon.net?

Original comment by cyber.sp...@gmail.com on 18 Jan 2012 at 9:54

Attachments:

GoogleCodeExporter commented 8 years ago 
I messaged a staff member on Rizon and they said that the problem had already 
been fixed for future episodes. Thanks for providing a thorough response to the 
issue. Reproducing all of VSFilter's non-standard behavior seems to be pretty 
painful, so thanks for your hard work.

Original comment by spacepir...@gmail.com on 18 Jan 2012 at 10:24

GoogleCodeExporter commented 8 years ago 
Fixed in 3.0.0.2

Original comment by cyber.sp...@gmail.com on 24 Jan 2012 at 2:34