search

okamibl / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter
0 stars 0 forks source link

\t or \ t within brackets { }, without any vaild transform or tags following, causes a crash #74

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

1. Playing a line containing a '\' within comment brackets without any actual 
command following.
2. Attached script has one at 18:14.63.
3. Removing the '\' solved the issue.

What is the expected output? What do you see instead?
Expected output - nothing, as it's a comment.
Given output - crash to desktop. ;)

What version of the product are you using? On what operating system?
3.0.0.1 on Windows 7 64bit with MPC.

Additional Information:
Line in question is:
Dialogue: 0,0:18:14.63,0:18:16.58,DialogueH,,0000,0000,0000,,If you don't want 
to eat it, then just say so. {:\ this is dumb - swearing}{fixed~}

Original issue reported on code.google.com by corocor...@gmail.com on 19 Jan 2012 at 10:09

Attachments:

GoogleCodeExporter commented 8 years ago 
Reproduced, but it's a bit weird. If I strip down the line in certain ways, I 
won't get a crash. 

Hmm... After a bit of testing, the crash seem to be caused by \ t within 
brackets without any valid command following. If we're lucky, this will be the 
one and only script to ever trigger this bug. Will be fixed once the dev 
returns from his break.

It's good to see that a few of these hard to find parser bugs are finally 
getting tracked down with this influx of new users over the past day.

Original comment by cyber.sp...@gmail.com on 19 Jan 2012 at 11:09

GoogleCodeExporter commented 8 years ago

Original comment by cyber.sp...@gmail.com on 21 Jan 2012 at 9:28

GoogleCodeExporter commented 8 years ago 
A patch for this. Note that this is the same bug as issue #73.

Original comment by tgoyne on 24 Jan 2012 at 1:34

Attachments:

GoogleCodeExporter commented 8 years ago 
Fixed in 3.0.0.2

Original comment by cyber.sp...@gmail.com on 24 Jan 2012 at 2:34

GoogleCodeExporter commented 8 years ago 
Thanks for the patch Plorkyeran. The solution was simpler than I would have 
thought.

I've attached three patches I used to build 3.0.0.2 to this post, since I don't 
have GIT access. The MFC Patches in particular will likely change somewhat, 
since in their current form they prevent successful building xy-VSFilter debug.

Original comment by cyber.sp...@gmail.com on 24 Jan 2012 at 2:52

Attachments: