search

okamibl / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter
0 stars 0 forks source link

Line with \fay visually breaks if any override tag is used [VSFilter quirk which works differently in Libass] #76

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Line with \fay visually breaks if any override tag is used.
Doesn't breaks in libass.

Screenshot and sample script attached.

Original issue reported on code.google.com by wOxxOm on 22 Jan 2012 at 10:56

Attachments:

GoogleCodeExporter commented 8 years ago 
That is just how VSFilter has always handled such lines, and since VSFilter is 
the reference rasterizer for the SSA/ASS spec, the bug is actually in Libass 
for not mimicking VSFilter behavior.

We have no intention of fixing any of the classic VSFilter quirks. Unless you 
somehow convince jfs and the other Aegisub devs that this should be fixed in 
VSFilter, our stance won't change.

Original comment by cyber.sp...@gmail.com on 22 Jan 2012 at 8:27

GoogleCodeExporter commented 8 years ago 
\fax \fay and other modern hacks are in no way The Classic VSFilter, since they 
were added by a few fansubbing enthusiasts, so fixing it in as many vsf mods as 
soon as possible seems justified.

Original comment by wOxxOm on 22 Jan 2012 at 8:38

GoogleCodeExporter commented 8 years ago 
As I said, you'll need to convince jfs (Aegisub dev + the coder who originally 
hacked \fax \fay into VSFilter in 2007) that this should be fixed.

Original comment by cyber.sp...@gmail.com on 22 Jan 2012 at 8:49

GoogleCodeExporter commented 8 years ago 
The \fax\fay patch was not mine, I received it from someone else, and don't 
know who originally wrote it. I just committed it as it was to the guliverkli2 
repository.

What I suggest to always consider when changing any behaviour is the installed 
base: How would it affect the (probably) couple million users if the meaning of 
some tag suddenly changed and producers of subtitles would suddenly start 
distributing subs made for a different behaviour?
In this case, I don't think the impact would be very large, however.

Either way, it is (should be) possible to transform any \fax\fay\frz into 
\fax\frz which does behave correctly. From my own quick experiment it looks 
like the math might not work out exactly as-implemented, but {\fay0.5} is 
approximately equivalent to {\fax0.5\frz-26} except that the latter does not 
cause the weird breaking.

Original comment by jiifur...@gmail.com on 22 Jan 2012 at 9:18

GoogleCodeExporter commented 8 years ago 
Issue 140 has been merged into this issue.

Original comment by cyber.sp...@gmail.com on 9 Mar 2013 at 7:21