okareshaba / openintents

Automatically exported from code.google.com/p/openintents
0 stars 0 forks source link

Color Picker should return new color on back button press #296

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Launch the OI Color Picker
2. Press the hardware back button on your device

What is the expected output? What do you see instead?
Current: I get RESULT_CANCELED and no color from the Color Picker.
Expected: The color I selected should have been returned in an Intent.

What version of the product are you using? On what operating system?
OI Color Picker 1.0.0 on Android 2.1

Please provide any additional information below.
The color selector should treat the back button like it's treated in other 
places (like preferences) in Android.  See this e-mail thread for reference:
http://www.mail-archive.com/android-developers@googlegroups.com/msg57059.html

Original issue reported on code.google.com by johan.walles@gmail.com on 19 Aug 2010 at 3:42

GoogleCodeExporter commented 9 years ago

Original comment by peli0...@googlemail.com on 30 Jan 2011 at 2:08

GoogleCodeExporter commented 9 years ago
By making the back button change the color by default, there is no way to 
"cancel" the action.

My solution is to prompt the user upon back press as to whether they actually 
want to change the color, and remind them that the center circle is another way 
to do it.

Fixed by commit 3123, will appear in v1.2.0 of color picker.

Original comment by kostmo on 6 Feb 2011 at 9:02