search

okaywit / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

Infinite loop in ClassPath with directories that contain cycles #1465

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We just ran into a bug where the ClassPath helper runs in to an infinite loop 
(and eventually runs out of perm gen space) with directories that contain 
cycles (e.g. via symlinks). I believe guava should log and otherwise ignore 
such cycles. 

I posted two corresponding comments in a code review that describes a fix, 
here: 
https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/com
mon/reflect/ClassPath.java?spec=svn7c3a7b17ff193720dc57ccf21aaa5525a75b3ffb&r=fa
b8b9744496a0ebca5232863ab186b7ac63c8e0#269

Thoughts?

Original issue reported on code.google.com by whosc...@cloudera.com on 2 Jul 2013 at 2:04

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 2 Jul 2013 at 3:39

GoogleCodeExporter commented 9 years ago 
Yeah SGTM.

I'll fix it.

Original comment by be...@google.com on 2 Jul 2013 at 11:53

GoogleCodeExporter commented 9 years ago

Original comment by be...@google.com on 10 Jul 2013 at 4:21

GoogleCodeExporter commented 9 years ago 
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<issue id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:12

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:08