search

okaywit / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

FutureCallback.onFailure javadoc is incorrect. #1483

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Guava version 14.0.1

Documentation for onFailure states

> If the future's get method throws an ExecutionException, then the 
> cause is passed to this method. Any other thrown object is passed
> unaltered.

In my code, the `onFailure` is called with the unwrapped `ExecutionException`.

I don't care whether `ExecutionException` is unwrapped or not (I can do that 
myself), I want the documentation to state what's going on.

Original issue reported on code.google.com by sash...@gmail.com on 19 Jul 2013 at 5:42

GoogleCodeExporter commented 9 years ago 
Would this be clearer?

"If the future's get method throws an ExecutionException, then the 
ExecutionException's cause is passed to this method."

Original comment by cpov...@google.com on 19 Jul 2013 at 5:48

GoogleCodeExporter commented 9 years ago 
Please disregard, user error.

Original comment by sash...@gmail.com on 19 Jul 2013 at 6:20

GoogleCodeExporter commented 9 years ago

Original comment by cpov...@google.com on 19 Jul 2013 at 6:22

GoogleCodeExporter commented 9 years ago 
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<issue id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:12

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:08