okaziya / cv

My personal CV project
https://okaziya.github.io/cv/
The Unlicense
0 stars 0 forks source link

Add language support for Swedish and English #5

Closed okaziya closed 1 week ago

okaziya commented 2 weeks ago

See #1 for designs.

mblomdahl commented 2 weeks ago

@okaziya I was thinking about the localization discussion we had yesterday, about how it's beneficial to have static-exports of the app into different language versions.

On the Swedish version, a button like this in the top-right corner linking to https://okaziya.github.io/cv/en/:

image

On the English version, a button like this in the top-right corner linking to https://okaziya.github.io/cv/sv/:

image

At least for me, I always know if my client prefer English or Swedish version beforehand, so it would be much more convenient to send them a https://mblomdahl.github.io/cv/sv/ link, than to expect them to find and press a language switch button (or, even worse, have to update their web browser locale preference to get the right version).

Ping @mkl-adsn, FYI! (Feel free to disagree!)

mkl-adsn commented 2 weeks ago

@mblomdahl Not a bad idea at all! Made a quick design for it: https://www.figma.com/proto/m9dxY4C87AiwRn8qyzDHs9/Liza-CV-Site?page-id=0%3A1&node-id=109-1451&node-type=canvas&viewport=3348%2C1683%2C1&t=0XxfEgjtFm1EszSE-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=109%3A1451&show-proto-sidebar=1

okaziya commented 1 week ago

Resolved with #9