search

okbob / ncurses-st-menu

ncurses (pdcurses) based library for CUA look menu
BSD 2-Clause "Simplified" License
62 stars 9 forks source link

remove autogen + configure-generated files #8

Closed GitMensch closed 4 years ago

GitMensch commented 4 years ago

When looking at @tysenmoore-xse's repo we also see that as long as the generated files are in it happens that those are adjusted and committed, instead of the "sources", which is another reason to remove them.

Together with the deletion I suggest to add those files to git ignore.

tysenmoore-xse commented 4 years ago

@GitMensch In my latest PR I removed the configure file as well and added it to the cleanconfig and .gitignore. I missed it in my previous changes. My PR already had the config.make and st_menu.pc.

GitMensch commented 4 years ago

Hm, the two extra files are not part of your latest commit, it only has a delete on the configure script (those two files are part of gitignore which may be a reason for some issues).

@okbob I suggest to get rid of those three files, also adding them to gitignore where missing - and additional consider to remove aclocal.m4 (from repo, added to gitignore), too; as it also gets in during autoconf.

okbob commented 4 years ago

"configure" should to stay. No every body has installed autoconf.

Should be cleaned now - af4a96f4da2c14ee6ab582dae3438a04be109844 b7ac47ae5ba6f7547656fb49e58c16cf32e5e9c7

GitMensch commented 4 years ago

@okbob actually I suggest to have the repo only contain everything that cannot be generated. As soon as this is in sight I'd suggest (and do the work + PR if accepted) to use a CI build to auto-generate a tarball which contains everything needed. To get an idea: https://sourceforge.net/p/open-cobol/code/HEAD/tree/branches/gnucobol-3.x/ + https://ci.appveyor.com/project/GitMensch/gnucobol-3-x :-)

okbob commented 4 years ago

st 26. 2. 2020 v 19:07 odesílatel Simon Sobisch notifications@github.com napsal:

@okbob https://github.com/okbob actually I suggest to have the repo only contain everything that cannot be generated. As soon as this is in sight I'd suggest (and do the work + PR if accepted) to use a CI build to auto-generate a tarball which contains everything needed. To get an idea: https://sourceforge.net/p/open-cobol/code/HEAD/tree/branches/gnucobol-3.x/

I understand, but for some people can be more easy to have "configure" file. Same rule has postgres.

—

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/okbob/ncurses-st-menu/issues/8?email_source=notifications&email_token=AAEFO44SM75IG75AAK7BTADRE2VXDA5CNFSM4K3QYOP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENBIWDQ#issuecomment-591563534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFO45RJ2P2M5V2JG4J4MTRE2VXDANCNFSM4K3QYOPQ .