Added PDCurses Compatibility #2

[tysenmoore-xse]

Updated PR for my PDCurses compatibility changes. Some updates:

• Merged latest ncurses-st-menu changes (simple2, etc)
• Fixed warnings when running autogen.sh
• Fixed lib deps not getting cleared when not building PDCurses
• Removed use of BUILD_OS_WIN, now m4 check creating HAVE_LANGINFO_CODESET
• Added screenshot for X11 PDCurses
• Updates to README (updated the usage example, build info, added PDCurses specific section, etc)
• Removed the configure file from the repo and added to cleanconfig/.gitignore (since auto generated in autogen.sh)

[okbob]

I please, can you do rebase first. I cannot to merge your branch.

More I don't understand to:

    #ifndef HAVE_LANGINFO_CODESET
    /* Don't use UTF when terminal doesn't use UTF */
    config.encoding = nl_langinfo(CODESET);
    #else
    config.encoding = "";
    #endif

or

#ifndef HAVE_LANGINFO_CODESET
#include 
#endif

It looks like strage - like HAVE_LANGINFO_CODESET has negative value what it should to have.

[tysenmoore-xse]

Nice catch, very sorry. I also did a rebase of my fork. Not sure if there is something else I need to do to fix the conflicts.

[GitMensch]

The current state is not mergeable and would create a strange history, too.

@tysenmoore-xse I suggest to wait for @okbob to do #8, then create a complete copy of your checkout, then delete the fork, then recreate it, checkout, diff your changes in, commit, create a new "clean" PR.

[tysenmoore-xse]

That works for me. I can wait.

[okbob]

I cleaned the projects - so please, refresh pull request

[tysenmoore-xse]

I am in the process of a new merge on a new fork. However, I did notice you still have the configure file checked in and not part of the gitignore/cleanup. Any specific reason? This is a generated file and should not be checked in to avoid confusion/build problems.

[okbob]

st 26. 2. 2020 v 19:58 odesílatel Tysen Moore notifications@github.com napsal:

I am in the process of a new merge on a new fork. However, I did notice you still have the configure file checked in and not part of the gitignore/cleanup. Any specific reason? This is a generated file and should not be checked in to avoid confusion/build problems.

I know it. On almost linux system this file is same - so if I have it in base, then lot of people doesn't need to install and run autogen.

It is very similar with Postgres https://github.com/postgres/postgres

And I am a PostgreSQL's boy :)

Pavel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/okbob/ncurses-st-menu/pull/9?email_source=notifications&email_token=AAEFO46WRO3PSCRHOX3SIBTRE23VPA5CNFSM4K33LRDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENBOILQ#issuecomment-591586350, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFO464XMXBYXW7JVX7KZLRE23VPANCNFSM4K33LRDA .