search

okd-project / okd-coreos-pipeline

Tekton pipeline for running coreos-assembler builds
Apache License 2.0
13 stars 11 forks source link

sig-cloud-okd repo hard coded with 4.14 version #55

Open jcapiitao opened 1 year ago

jcapiitao commented 1 year ago

The release in sig-cloud-okd repo is hardcoded which is consumed by all the releases pipelines. I guess it's not critical currently as 4.15 may not diverged too much from 4.14, but it might be in the future.

We can fix it with a sed 's/4.14/4.15/' alike command after the cosa-init execution as we do for the RPM artifacts https://github.com/okd-project/okd-coreos-pipeline/blob/487be68ce116b8b06360f23d6f49fd37735a684e/base/tekton.dev/tasks/cosa-init.yaml#L61 The second option is to define the whole repo and add it at the end of src/config/c9s.repo as we do for artifacts https://github.com/okd-project/okd-coreos-pipeline/blob/487be68ce116b8b06360f23d6f49fd37735a684e/base/tekton.dev/tasks/cosa-init.yaml#L62-L71 This option is better aligned with the layerd build effort #46 as, IIUC, the sig-cloud-okd repo definition in src/config/c9s.repo will be removed at the end (to separate SCOS and OKD).

But we first need to tag the builds in the cloud9s-okd-4.15-release tag I can do the tags, and even build the new NVRs but I'd need the exact version of what's in 4.15 release

jcapiitao commented 1 year ago

Actually, based on this commit https://github.com/openshift/os/commit/b157aa70682fa5ee94439f01c5caa10ec88daa47 I think we should rename the sig-cloud-okd repo to sig-cloud-okd-X.Y for the sake of consistency. And then in cosa-init task, edit it to whatever release defined in task.

LorbusChris commented 1 year ago

Thanks for raising this! I'm not really a fan of doing these downstream sed hacks, but it's certainly an option.

And yes, we definitely need the CBS builds tag.

Related: https://github.com/openshift/os/pull/1375

jcapiitao commented 1 year ago

Do you want me to take care of the CBS tags ?