search

okd-project / okd

The self-managing, auto-upgrading, Kubernetes distribution for everyone
https://okd.io
Apache License 2.0
1.72k stars 295 forks source link

Collect images built by Fedora and reconfigure samples-operator to use those #167

Open vrutkovs opened 4 years ago

vrutkovs commented 4 years ago

See https://registry.fedoraproject.org/ - OKD should promote Fedora content and inject a configuration to samples-operator, which adds these imagestreams.

TODO:

cragr commented 4 years ago

Typically I use the s2i CentOS 7 images on my OKD cluster. I was envisioning an OKD specific catalog that would hold CentOS and Fedora image specific templates and image streams. The fedora images do not appear to reside anywhere but they can be built using the Dockerfile.fedora. Here is an example of a shortlist I gathered because I suspect something different is being requested or in a different format and will await further instructions before proceeding. There is also a library here including a community folder: https://github.com/openshift/library

s2i-perl-container podman pull centos/perl-530-centos7 https://github.com/sclorg/s2i-perl-container/blob/master/imagestreams/perl-centos7.json https://github.com/sclorg/s2i-perl-container/blob/master/5.30/Dockerfile.fedora

s2i-php-container podman pull centos/php-73-centos7 https://github.com/sclorg/s2i-php-container/blob/master/imagestreams/php-centos7.json https://github.com/sclorg/s2i-php-container/blob/master/7.3/Dockerfile.fedora

nginx-container podman pull centos/nginx-116-centos7 https://github.com/sclorg/nginx-container/blob/master/imagestreams/nginx-centos7.json https://github.com/sclorg/nginx-container/blob/master/1.18/Dockerfile.fedora

s2i-nodejs-container podman pull centos/nodejs-8-centos7 https://github.com/sclorg/s2i-nodejs-container/blob/master/imagestreams/nodejs-centos7.json https://github.com/sclorg/s2i-nodejs-container/blob/master/12/Dockerfile.fedora

s2i-ruby-container podman pull centos/ruby-27-centos7 https://github.com/sclorg/s2i-ruby-container/blob/master/imagestreams/ruby-centos7.json https://github.com/sclorg/s2i-ruby-container/blob/master/2.7/Dockerfile.fedora

httpd-container podman pull centos/httpd-24-centos7 https://github.com/sclorg/httpd-container/blob/master/imagestreams/httpd-centos7.json https://github.com/sclorg/httpd-container/blob/master/2.4/Dockerfile.fedora

cragr commented 4 years ago

Here are some fedora based images I created and uploaded to Dockerhub. Should I build and upload more?

cragr/mysql-80-fedora cragr/php-73-fedora cragr/php-72-fedora cragr/mariadb-103-fedora cragr/redis-5-fedora cragr/redis-6-fedora cragr/httpd-24-fedora

vrutkovs commented 4 years ago

That would be great, but we can't yet include them in the OKD. Lets have them built and maintained by Fedora so that we'd make sure these don't go stale and get security updates frequently

cragr commented 4 years ago

See https://registry.fedoraproject.org/ - OKD should promote Fedora content and inject a configuration to samples-operator, which adds these imagestreams.

TODO:

TODO:

cragr commented 4 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=1859387

I read through Container Review Process and am attempting to become a contributor so I can update the container images and push them to the fedora registry. There are many other fedora images I can submit but I want to see how this one goes before I put in the additional work.

What about the CentOS7 images can we start with those while we wait on the Fedora Container SIG/Review Process?

cragr commented 4 years ago

This link appears to have everything needed for CentOS 7 images: https://github.com/openshift/library/tree/master/community

CentOS 7 image list (incomplete):

mariadb-container centos/mariadb-102-centos7 centos/mariadb-103-centos7

s2i-python-container centos/python-27-centos7 centos/python-36-centos7 centos/python-38-centos7

s2i-php-container centos/php-72-centos7 centos/php-73-centos7

s2i-perl-container centos/perl-526-centos7

nginx-container centos/nginx-114-centos7 centos/nginx-116-centos7

s2i-nodejs-container centos/nodejs-10-centos7 centos/nodejs-12-centos7

s2i-ruby-container centos/ruby-25-centos7 centos/ruby-26-centos7 centos/ruby-27-centos7

httpd-container centos/httpd-24-centos7

redis-container centos/redis-5-centos7

postgresql-container centos/postgresql-96-centos7 centos/postgresql-10-centos7 centos/postgresql-12-centos7

mysql-container centos/mysql-80-centos7

varnish-container centos/varnish-5-centos7 centos/varnish-6-centos7

mongodb-container centos/mongodb-34-centos7 centos/mongodb-36-centos7

cassandra-container centos/cassandra-311-centos7

cragr commented 4 years ago

I created an issue on these repos to see how it goes before I work on the rest.

https://github.com/sclorg/s2i-php-container/issues/298 https://github.com/sclorg/mariadb-container/issues/131

bdlink commented 4 years ago

The fedora:latest base image is 183MB compared to ubuntu:latest (73.9MB), debian:stable-slim (69.2MB) or debian:latest(114MB). Do we need everything that is in it or would a smaller base image by preferable?

Conan-Kudo commented 4 years ago

There's a fedora:minimal base image that's ~110MB if we really wanted to switch to minimal with microdnf instead of dnf. But minimal size isn't everything, and reusability of total set of components can help minimize total deployment size anyway.

Additionally, @asamalik is working on shrinking the base more without doing chainsaw maneuvers that those images you mention do (essentially clean setups instead of hacksaw ones).

vrutkovs commented 4 years ago

In OKD 4.6 samples operator would use imagestreams defined in https://github.com/openshift/library/tree/master/community, any additional imagestreams need to be submitted there.

There is no easy fix for OKD 4.5 though, as it may break existing installations

sapkra commented 4 years ago

Do you know the currently estimated release date for 4.6?

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

Conan-Kudo commented 3 years ago

/remove-lifecycle rotten

Conan-Kudo commented 3 years ago

/lifecycle frozen

phracek commented 1 year ago

All Software Collection images now live on quay.io registry. CentOS 7 is here: https://quay.io/organization/centos7. For Fedora images lives here: https://quay.io/organization/fedora

LorbusChris commented 1 year ago

See:

After that merges, someone will have to go through https://github.com/openshift/library/blob/master/community.yaml and for check all the imported imagestreams whether automated Fedora/C9S/public UBI builds exist.

I've started with that here: