okd-project / okd

The self-managing, auto-upgrading, Kubernetes distribution for everyone
https://okd.io
Apache License 2.0
1.7k stars 294 forks source link

[docs] OKD docs should use Ignition v3 examples instead of v2 #184

Closed jomeier closed 3 years ago

jomeier commented 4 years ago

Hi,

here:

https://docs.okd.io/latest/installing/installing_vsphere/installing-vsphere.html

I found a bug.

The example for 'append_bootstrap.ign' contains 'append' (Ignition v2) instead of 'merge' (Ignition v3).

If we use 'append' Fedora Core OS won't configure itself.

Greetings,

Josef

vrutkovs commented 4 years ago

Renamed it to be a bit more generic:

Bengrunt commented 4 years ago

The same issue exists for the Openstack (UPI) installation documentation: https://docs.okd.io/latest/installing/installing_openstack/installing-openstack-user.html#installation-osp-converting-ignition-resources_installing-openstack-user

This is a bit unsettling when following the installation instructions, especially when not really familiar with ignition.

vrutkovs commented 4 years ago

This would be effectively fixed when OCP 4.6 documentation is out, as it uses Ignition 3

jomeier commented 4 years ago

The initial problem in the docs is fixed for vSphere.

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

vrutkovs commented 3 years ago

OCP 4.6 switched to Ignition 3, so OKD docs now contain config examples with Ignition 3