search

okdistribute / hyperdrive-ui

Render a hyperdrive in the browser.
http://karissa.github.io/hyperdrive-ui/
40 stars 4 forks source link

Add standard lint to pre-commit hook. #40

Closed clkao closed 8 years ago

clkao commented 8 years ago

Closes #39

juliangruber commented 8 years ago

+1 for the lint script, but -1 from me on the pre-commit hook. those just keep annoying me :/

clkao commented 8 years ago

Is it the additional stdout being annoying (this can be disabled easily)? or the fact the lint is run during pre-commit?

I found this useful for reducing roundtrips in casual PR not noticing the styles. Alternatively, we can also add a CI check in github though.

juliangruber commented 8 years ago

It's simply that i run npm test before committing anyways, so this would be two lint runs

clkao commented 8 years ago

Oh this repo has no npm test yet ;)

mafintosh commented 8 years ago

i'd add standard as the test script and add travis to this repo. that works quite well.

mafintosh commented 8 years ago

and not have the precommit hook. you can have an npm script that sets that up though if it helps your workflow :)

clkao commented 8 years ago

ok this is being the sole npm test for now, and travis is enabled in my fork: https://travis-ci.org/clkao/hyperdrive-ui/builds/136925488

@karissa can you enable travis-ci in this repo?

okdistribute commented 8 years ago

ok activated on travis!