search

okfde / ckanext-offenedaten

CKAN extension for OffeneDaten.de (theme/UI & harvesters)
http://www.offenedaten.de
4 stars 3 forks source link

Add disqus discussions to dataset pages #2

Closed domoritz closed 11 years ago

domoritz commented 11 years ago

Will need the https://github.com/okfn/ckanext-disqus extension to be installed.

domoritz commented 11 years ago

@stefanw @jbspeakr Any thoughts on this?

jbspeakr commented 11 years ago

in my eyes, a nice to have feature... probably also interesting for the pdeu thingy?!

stefanw commented 11 years ago

Did you check that it works? Last time I tried, the extension was broken Genshi-style. Anyways, looks good. Feel free to merge away!

domoritz commented 11 years ago

@stefanw Last time I checked, it worked. I'll need to make sure that it's still working, though. I just wanted to know what you guys think about this feature.

stefanw commented 11 years ago

Well, comments are a nice feature. Disqus is coming with embedded ads now, which is not that nice. Maybe it could be time for a ckanext-comments? Shouldn't be too hard to build.

domoritz commented 11 years ago

Well, if they have ads, I think we should not add this feature yet.

jbspeakr commented 11 years ago

just checked various Disqus using blogs (e.g. crackajack.de) and couldn't find any ads?! maybe it's configurable? nerdcore

domoritz commented 11 years ago

Okay, I can confirm that the disqus extension works with the latest version of CKAN and this extension. Merging this now.

stefanw commented 11 years ago

They definitely have ads: http://jacquesmattheij.com/disqus-bait-and-switch-now-with-ads

They only appear after a while (I believe), typical bait and switch.

However, a future ckanext-comments extension will hopefully have a disqus import function.