okfde / fragdenstaat_de

Froide Theme for fragdenstaat.de
https://fragdenstaat.de
Other
125 stars 21 forks source link

Missing OSM attribution and issues with OSM data #184

Open jomo opened 3 years ago

jomo commented 3 years ago

See https://fragdenstaat.de/kampagnen/klimacheck/

☒ Attribution issues (solved)

  1. The background map is based on OSM data, but the required OSM attribution is missing.
    You might want to check if Carto requires attribution as well
  2. The POI labels and positions have been pulled from OSM, and there is no attribution for that, either.

I don't think mentioning "Open Street Map" [sic] somewhere hidden in the FAQ on a different page is sufficient, see https://www.openstreetmap.org/copyright for details.

☐ Issues with OSM data

The FAQ states that the POIs have been mapped as public buildings in OSM, which is not accurate.

It seems like you fetched all OSM objects with a leisure=sports_centre tag (among others). This tag is used on many privately owned sports facilities. This issue might also (less often) affect some other categories such as libraries and schools. Issues might also occur due to falsely tagged OSM data.

For a user of the website, it's not clear why these POIs are shown and I suggest displaying a text such as "This is shown because it was tagged as a school/library/government office/etc" in the POI pop-up. Maybe even add a button to report the POI as a false positive?

You could also display a small notice (e.g. above the map) along the lines of "This map lists government offices, schools, libraries, sports centres, etc. Note that some of these might not be public buildings."

alehaa commented 3 years ago

I like the idea of adding a button to report false positives. Filtering the data will never be 100% accurate.

jomo commented 3 years ago

The maps on FdS now have a link to http://osm.org/copyright. Therefore the attribution issue is solved – although HTTPS://osm.org/copyright would be better.