search

okfde / fragdenstaat_de

Froide Theme for fragdenstaat.de
https://fragdenstaat.de
Other
122 stars 21 forks source link

🩹 Blog: also apply blockquote if in figure #312

Closed pajowu closed 1 year ago

stefanw commented 1 year ago

Mh, right now there is 56% browser coverage for :has(), that's probably not enough. So maybe we need just figure and then with a class undo when we want full width figure? Also maybe @krmax44 should give an opinion as he is bound to redesign the blog at some point.

pajowu commented 1 year ago

Yes, I was conflicted on using has() as well because of the low adoption rate. On the other hand I'm not sure whether we need a fix at all: There currently is no way to create a blockquote inside a figure from the UI. I think this is only possible using the sourcecode mode of ckeditor or directly in the database. I would be fine with just closing this PR.

stefanw commented 1 year ago

As discussed, rather support a plugin that sets a specific class on a figure.