search

okfde / fragdenstaat_de

Froide Theme for fragdenstaat.de
https://fragdenstaat.de
Other
121 stars 21 forks source link

💄 crop hero image properly #444

Closed krmax44 closed 7 months ago

krmax44 commented 7 months ago

for hero images, the dimensions vary quite a bit between devices. this seems too specific for get_responsive_plugin_image. also it's important to take the set subject location into account.

before after
image image
pajowu commented 7 months ago

Would it make sense to extend get_responsive_filer_image to also return media-queries so we can reuse this in other places?

krmax44 commented 7 months ago

@pajowu I feel this is a very specific use-case. For mobile, we create square thumbnails, for everything else it's widescreen. We also crop into the images (which we otherwise don't), specifically to the subject center.